Change 27067: Oops. When changing warnings.pl one should re-run it. Well spotted

[nwc10+ (Nicholas Clark)]

Change 27067 by ***@profane on 2006/02/03 17:06:43

Oops. When changing warnings.pl one should re-run it. Well spotted
Rafael.

Affected files ...

... //depot/perl/warnings.h#27 edit

Differences ...

==== //depot/perl/warnings.h#27 (text+w) ====
Index: perl/warnings.h
--- perl/warnings.h#26~25050~ 2005-07-02 08:05:04.000000000 -0700
+++ perl/warnings.h 2006-02-03 09:06:43.000000000 -0800
@@ -17,9 +17,9 @@
#define G_WARN_ONCE 8 /* set if 'once' ever enabled */
#define G_WARN_ALL_MASK (G_WARN_ALL_ON|G_WARN_ALL_OFF)

-#define pWARN_STD Nullsv
-#define pWARN_ALL (Nullsv+1) /* use warnings 'all' */
-#define pWARN_NONE (Nullsv+2) /* no warnings 'all' */
+#define pWARN_STD NULL
+#define pWARN_ALL (NULL+1) /* use warnings 'all' */
+#define pWARN_NONE (NULL+2) /* no warnings 'all' */

#define specialWARN(x) ((x) == pWARN_STD || (x) == pWARN_ALL || \
(x) == pWARN_NONE)
End of Patch.

[John E. Malmberg]

Post by nwc10+ (Nicholas Clark)
Oops. When changing warnings.pl one should re-run it. Well spotted
Rafael.
Affected files ...
... //depot/perl/warnings.h#27 edit
Differences ...
==== //depot/perl/warnings.h#27 (text+w) ====
Index: perl/warnings.h
--- perl/warnings.h#26~25050~ 2005-07-02 08:05:04.000000000 -0700
+++ perl/warnings.h 2006-02-03 09:06:43.000000000 -0800
@@ -17,9 +17,9 @@
#define G_WARN_ONCE 8 /* set if 'once' ever enabled */
#define G_WARN_ALL_MASK (G_WARN_ALL_ON|G_WARN_ALL_OFF)
-#define pWARN_STD Nullsv
-#define pWARN_ALL (Nullsv+1) /* use warnings 'all' */
-#define pWARN_NONE (Nullsv+2) /* no warnings 'all' */
+#define pWARN_STD NULL
+#define pWARN_ALL (NULL+1) /* use warnings 'all' */
+#define pWARN_NONE (NULL+2) /* no warnings 'all' */
#define specialWARN(x) ((x) == pWARN_STD || (x) == pWARN_ALL || \
(x) == pWARN_NONE)
End of Patch.

The VMS C compiler, V 7.1 does not seem to like this change.

CC/DECC/NOANSI_ALIAS
/Include=[]/Standard=Relaxed_ANSI/Prefix=All/Obj=.obj/List/D
ebug/NoOpt/Show=(expansion,include)/machine/float=ieee/ieee=denorm/Define=(PERL_C
ORE,_LARGEFILE=1) MG.C

if (PL_compiling.cop_warnings == pWARN_NONE) {
.............................................^
%CC-W-BADPTRARITH, In this statement, performing pointer arithmetic on a
pointer to void or a pointer to function is not allowed. The compiler
will treat the type as if it were pointer to char.
at line number 801 in file PERL_BUILD_ROOT:[000000]mg.c;1

else if (PL_compiling.cop_warnings == pWARN_ALL) {
..................................................^
%CC-W-BADPTRARITH, In this statement, performing pointer arithmetic on a
pointer to void or a pointer to function is not allowed. The compiler
will treat the type as if it were pointer to char.
at line number 811 in file PERL_BUILD_ROOT:[000000]mg.c;1

PL_compiling.cop_warnings = pWARN_NONE;
................................................^
%CC-W-BADPTRARITH, In this statement, performing pointer arithmetic on a
pointer to void or a pointer to function is not allowed. The compiler
will treat the type as if it were pointer to char.
at line number 2251 in file PERL_BUILD_ROOT:[000000]mg.c;1

PL_compiling.cop_warnings = pWARN_NONE;
....................................................^
%CC-W-BADPTRARITH, In this statement, performing pointer arithmetic on a
pointer to void or a pointer to function is not allowed. The compiler
will treat the type as if it were pointer to char.
at line number 2264 in file PERL_BUILD_ROOT:[000000]mg.c;1

PL_compiling.cop_warnings = pWARN_ALL;
....................................................^
%CC-W-BADPTRARITH, In this statement, performing pointer arithmetic on a
pointer to void or a pointer to function is not allowed. The compiler
will treat the type as if it were pointer to char.
at line number 2266 in file PERL_BUILD_ROOT:[000000]mg.c;1

if (specialWARN(PL_compiling.cop_warnings))
............................^
%CC-W-BADPTRARITH, In this statement, performing pointer arithmetic on a
pointer to void or a pointer to function is not allowed. The compiler
will treat the type as if it were pointer to char.
at line number 2270 in file PERL_BUILD_ROOT:[000000]mg.c;1

-John
***@qsl.net
Personal Opinion Only

[Nicholas Clark]

Post by John E. Malmberg
The VMS C compiler, V 7.1 does not seem to like this change.

It's quite right not to. It's a shame that gcc isn't really a C compiler
even in maximum "ANSI" mode.

Should be fixed in change 27078

Nicholas Clark

[John E. Malmberg]

Post by Nicholas Clark

Post by John E. Malmberg
The VMS C compiler, V 7.1 does not seem to like this change.

It's quite right not to. It's a shame that gcc isn't really a C compiler
even in maximum "ANSI" mode.
Should be fixed in change 27078

EAGLE> type .patch
27081
EAGLE> search build.log "all tests"/window=3
t/x2p/s2p..................................................ok
All tests successful.
u=95.62 s=0.00 cu=0.00 cs=0.00 scripts=1085 tests=157306

Yes, that seems to have done the trick.

Thanks,
-John
***@qsl.net
Personal Opinion Only