Discussion:
[perl.git] branch blead, updated. v5.15.2-267-g924d3af
(too old to reply)
Nicholas Clark
2011-09-06 19:36:34 UTC
Permalink
In perl.git, the branch blead has been updated

<http://perl5.git.perl.org/perl.git/commitdiff/924d3af1d7b5591ebab03fef27f1aef6364027da?hp=a03432f295f78eec5042079a07e54fd2afb2e56e>

- Log -----------------------------------------------------------------
commit 924d3af1d7b5591ebab03fef27f1aef6364027da
Author: Nicholas Clark <***@ccl4.org>
Date: Tue Sep 6 15:06:06 2011 +0200

In Glob.xs, use memset() instead of bzero()

3c97495f56fb647c used bzero(), which isn't available on some platforms.
-----------------------------------------------------------------------

Summary of changes:
ext/File-Glob/Glob.xs | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ext/File-Glob/Glob.xs b/ext/File-Glob/Glob.xs
index 5a08a0d..91b9f4d 100644
--- a/ext/File-Glob/Glob.xs
+++ b/ext/File-Glob/Glob.xs
@@ -64,7 +64,7 @@ PPCODE:
}

/* call glob */
- bzero(&pglob, sizeof(glob_t));
+ memset(&pglob, 0, sizeof(glob_t));
retval = bsd_glob(pattern, flags, errfunc, &pglob);
GLOB_ERROR = retval;


--
Perl5 Master Repository
Craig A. Berry
2011-09-08 03:36:20 UTC
Permalink
Post by Nicholas Clark
In perl.git, the branch blead has been updated
<http://perl5.git.perl.org/perl.git/commitdiff/924d3af1d7b5591ebab03fef27f1aef
6364027da?hp=a03432f295f78eec5042079a07e54fd2afb2e56e>
- Log -----------------------------------------------------------------
commit 924d3af1d7b5591ebab03fef27f1aef6364027da
Date: Tue Sep 6 15:06:06 2011 +0200
In Glob.xs, use memset() instead of bzero()
3c97495f56fb647c used bzero(), which isn't available on some platforms.
-----------------------------------------------------------------------
ext/File-Glob/Glob.xs | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ext/File-Glob/Glob.xs b/ext/File-Glob/Glob.xs
index 5a08a0d..91b9f4d 100644
--- a/ext/File-Glob/Glob.xs
+++ b/ext/File-Glob/Glob.xs
}
/* call glob */
- bzero(&pglob, sizeof(glob_t));
+ memset(&pglob, 0, sizeof(glob_t));
Urk. I intentionally used bzero based on a memory that it was more
portable. I guess I'm going to have to claim that this memory was
falsely implanted during an alien abduction as I now see that memset is
in the C standard but bzero is not.

Florian has already grabbed this for maint-5.14. I've now pulled it
into maint-5.12 as well.

Sorry to leave crumbs for others to clean up.

Loading...